Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time graph filtering and collapsing #302

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

PatrickTasse
Copy link
Contributor

@PatrickTasse PatrickTasse commented Oct 17, 2024

Only clear excluded rows if the EXCLUDED filtering expressions have changed. This prevents unnecessarily redoing filtering of rows when only the search string has changed.

Determine the list of rows that have only changed y-position, for example due to collapsing of preceding rows. If these rows do not need to be fetched because their current model is valid, then rebuild the rows using their current model to update each child element's position.

If no rows at all need to be fetched but there were some moved rows, perform a fetch to update the arrows which may have changed their start and/or end position.

Remove unused code for updating and removing of gap states, as the states and gaps are always added from scratch when updating a row. Remove the reference to gap state components in the row model states.

Fixes eclipse-cdt-cloud/theia-trace-extension#1132

Only clear excluded rows if the EXCLUDED filtering expressions have
changed. This prevents unnecessarily redoing filtering of rows when only
the search string has changed.

Determine the list of rows that have only changed y-position, for
example due to collapsing of preceding rows. If these rows do not need
to be fetched because their current model is valid, then rebuild the
rows using their current model to update each child element's position.

If no rows at all need to be fetched but there were some moved rows,
perform a fetch to update the arrows which may have changed their start
and/or end position.

Remove unused code for updating and removing of gap states, as the
states and gaps are always added from scratch when updating a row.
Remove the reference to gap state components in the row model states.

Signed-off-by: Patrick Tasse <[email protected]>
Copy link
Collaborator

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in conjunction with: eclipse-cdt-cloud/theia-trace-extension#1131 and it looks good. Thanks.

@PatrickTasse PatrickTasse merged commit 911d55b into eclipse-cdt-cloud:master Oct 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time graph filtering and collapsing not working properly.
2 participants