Emit ControllerAddress changed signal in SwitchController method #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwperina
reviewed
Oct 25, 2024
engelmi
force-pushed
the
add-agent-address-changed-signal-to-switch-method
branch
from
8251586
to
0957b90
Compare
|
/packit retest-failed |
1 similar comment
|
/packit retest-failed |
The changed signal for the agents ControllerAddress property was emitted only in the agent_reconnect function when a change in the address has been detected. This, however, led to the agent first emitting a status disconnected signal and then the address changed signal when the SwitchAddress API has been called. The order of these signals should be reversed. The address changed signal is now also emitted inside the SwitchController API function which changes the address. In order to get the up-to-date value in the orch_addr field, the new value is set here as well. The ControllerAddress property changed signal will still be emitted in the reconnect function to ensure any change in the address due to name resolution is considered. Signed-off-by: Michael Engel <[email protected]>
engelmi
force-pushed
the
add-agent-address-changed-signal-to-switch-method
branch
from
0957b90
to
95ffd63
Compare
mkemel
reviewed
Oct 28, 2024
Signed-off-by: Michael Engel <[email protected]>
Signed-off-by: Michael Engel <[email protected]>
|
/packit retest-failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #964
The changed signal for the agents ControllerAddress property was emitted only in the agent_reconnect function when a change in the address has been detected. This, however, led to the agent first emitting a status disconnected signal and then the address changed signal when the SwitchAddress API has been called. The order of these signals should be reversed.
The address changed signal is now also emitted inside the SwitchController API function which changes the address. In order to get the up-to-date value in the orch_addr field, the new value is set here as well.
The ControllerAddress property changed signal will still be emitted in the reconnect function to ensure any change in the address due to name resolution is considered.