-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Agent Register request asynchronous #961
Conversation
8790825
to
4995715
Compare
Ready for review. GH Integration tests failing at the prepare stage currently, probably infra issue |
/packit test --labels valgrind |
4995715
to
1ff7a55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
61dbf93
to
4fb58b2
Compare
Moved the PR back to draft, found a memory issue |
1e4b61e
to
6db1932
Compare
0331f47
to
7027c07
Compare
The "Register" agent->controller method call could get stuck when the IP address configured as ControllerHost does not exist. This timeout of about 2 seconds could completely occupy the event loop and would not allow other calls on the DBus API of the Agent. Making the "Register" method call asynchronous we allow the event loop to stay unoccupied and be able to accept SwitchController request. Resolves: eclipse-bluechi#950 Signed-off-by: Mark Kemel <[email protected]>
7027c07
to
4ad6f94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Great work!
The "Register" agent->controller method call could get stuck when the IP address configured as ControllerHost does not exist. This timeout of about 2 seconds could completely occupy the event loop and would not allow other calls on the DBus API of the Agent.
Making the "Register" method call asynchronous we allow the event loop to stay unoccupied and be able to accept SwitchController request.
Resolves: #950
Resolves: #966