Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GetUnitFileState API #953

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mwperina
Copy link
Member

@mwperina mwperina commented Sep 27, 2024

  • Adds support for GetUnitFileState API on controller and node
  • Adds is-enabled command to bluechictl
  • Adds integration test

Fixes: #934
Signed-off-by: Martin Perina [email protected]

@coveralls
Copy link

coveralls commented Sep 27, 2024

Coverage Status

coverage: 83.538% (-0.03%) from 83.569%
when pulling 6c8b545 on mwperina:get-unit-file-status
into 34d9e91 on eclipse-bluechi:main.

@mwperina
Copy link
Member Author

/packit test-failed

@mwperina
Copy link
Member Author

/packit retest-failed

@mwperina mwperina force-pushed the get-unit-file-status branch 2 times, most recently from 6e25ef1 to 0bca2e4 Compare September 30, 2024 13:12
@mwperina
Copy link
Member Author

/packit retest-failed

src/client/method-is-enabled.c Show resolved Hide resolved
src/client/method-is-enabled.c Outdated Show resolved Hide resolved
Copy link
Contributor

@ArtiomDivak ArtiomDivak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkemel
Copy link
Member

mkemel commented Oct 1, 2024

Looks great! Just a small improvement suggestion from my side

- Adds support for GetUnitFileState API on controller and node
- Adds is-enabled command to bluechictl
- Adds integration test

Fixes: eclipse-bluechi#934
Signed-off-by: Martin Perina <[email protected]>
Copy link
Member

@mkemel mkemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina
Copy link
Member Author

mwperina commented Oct 1, 2024

/packit retest-failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Add GetUnitFileState API
4 participants