Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test list-unit-files on a specific node #926

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

mwperina
Copy link
Member

Verifies that bluechictl list-unit-files reports the same units for a
specific node as systemctl list-unit-files executed on this node.

Signed-off-by: Martin Perina [email protected]

@coveralls
Copy link

coveralls commented Aug 12, 2024

Coverage Status

coverage: 85.348% (+0.7%) from 84.673%
when pulling 03fa8c7 on mwperina:main
into e5e4681 on eclipse-bluechi:main.

@engelmi
Copy link
Member

engelmi commented Aug 12, 2024

LGTM

There isn't an integration test like this for list-units - should we add it in the same go?

@mwperina
Copy link
Member Author

LGTM

There isn't an integration test like this for list-units - should we add it in the same go?

We are calling list-units on a specific node in https://github.com/eclipse-bluechi/bluechi/blob/main/tests/tests/tier0/bluechi-agent-resolve-fqdn/test_bluechi_agent_resolve_fqdn.py#L38 that's why code coverage isn't complaining.
But you are right, we should have a specific test for it, I will create a new PR for that

Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Verifies that bluechictl list-unit-files reports the same units for a
specific node as systemctl list-unit-files executed on this node.

Signed-off-by: Martin Perina <[email protected]>
@engelmi
Copy link
Member

engelmi commented Aug 13, 2024

/packit test

@engelmi engelmi merged commit 704cef6 into eclipse-bluechi:main Aug 13, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants