Add to check the liveness for connection with controller #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dofmind
requested review from
alexlarsson,
engelmi,
mkemel and
rhatdan
as code owners
dofmind
force-pushed
the
check-liveness
branch
4 times, most recently
from
576d0f9
to
28a82bf
Compare
|
Hi @dofmind, This PR comprises of a new feature to be added to BlueChi. It is highly recommended to file a new issue before creating a PR. This way we can discuss it upfront and keep the review of the PR(s) concise. About the feature itself: |
engelmi
reviewed
Aug 12, 2024
This adds a new heartbeat signal for internal DBus to controller, also adds a new option to agent: ControllerHeartbeatThreshold. The controller emits the heartbeat signal like agent. The agent writes last seen timestamp for connection with controller if it receives the heartbeat signal from controller, and the agent periodically checks the last seen timestamp for connection with controller, and if it was sent before ControllerHeartbeatThreshold, the agent treats it as disconnected. If ControllerHeartbeatThreshold value is 0, it is disabled to check the liveness for connection with controller, and the default value is 0. Signed-off-by: Joonyoung Shim <[email protected]>
dofmind
force-pushed
the
check-liveness
branch
from
28a82bf
to
f188374
Compare
An integration test is to verify if the agent gets disconnected when did not receive heartbeat since threshold from controller. Signed-off-by: Joonyoung Shim <[email protected]>
dofmind
force-pushed
the
check-liveness
branch
from
f188374
to
19ba4a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is that agent can detect disconnection with controller faster, like controller.
Also includes an integration test to test this feature.
This adds a new heartbeat signal for internal DBus to controller, also
adds a new option to agent: ControllerHeartbeatThreshold.
The controller emits the heartbeat signal like agent. The agent writes
last seen timestamp for connection with controller if it receives the
heartbeat signal from controller, and the agent periodically checks the
last seen timestamp for connection with controller, and if it was sent
before ControllerHeartbeatThreshold, the agent treats it as
disconnected.
If ControllerHeartbeatThreshold value is 0, it is disabled to check the
liveness for connection with controller, and the default value is 0.