Replaced tmt duplicate test ID check

In teemtee/tmt#2939, tmt (>=1.35) extended its linting feature to also detect duplicate IDs in tests, plans and stories. Therefore, the duplicate-ids python script can be removed and the CI be updated to use tmt lint instead. Signed-off-by: Michael Engel <[email protected]>
eclipse-bluechi · Aug 21, 2024 · 641e4ce · 641e4ce
1 parent 4f6c0f5
commit 641e4ce
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 72 deletions.
diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml
@@ -91,10 +91,10 @@ jobs:
           tmt test id --dry | grep "New id" && echo "Found integration tests with missing ID. Please generate Test-IDs." && exit 1
           cd ..
       
-      - name: Check for duplicate test IDs and summaries
+      - name: Lint tmt tests, plans and stories
         run: |
           cd tests
-          ./scripts/duplicate-check.py
+          tmt lint
           cd ..
 
       - name: Run integration tests

diff --git a/tests/README.md b/tests/README.md
@@ -1,4 +1,5 @@
 <!-- markdownlint-disable-file MD013 -->
+
 # Eclipse BlueChi&trade; integration tests
 
 ## Installation
@@ -203,17 +204,16 @@ New id 'UUID' added to test '/tests/path_to_your_new_test'.
 
 ### Checking for duplicate test IDs and summaries
 
-In addition to having a unique ID, the summaries of tests should be descriptive and unique as well. An automatic check will be performed by the CI. This check can also be invoked locally:
+In addition to having a unique ID, the summaries of tests should be descriptive and unique as well. The CI will perform appropriate linting. This can also be invoked locally:
 
 ```shell
 $ cd ~/bluechi/tests
-$ ./scripts/duplicate-check.py
-Duplicate ID '254b1fa2-7c9f-481c-85ac-c6e42c0226c8' detected for tests:
-        /tests/tier0/bluechi-anonymous-node
-        /tests/tier0/bluechi-controller-set-loglevel-invalid
-Duplicate summary detected for tests:
-        /tests/tier0/bluechi-agent-set-loglevel
-        /tests/tier0/bluechi-controller-set-loglevel
+
+# requires tmt >= 1.35
+$ tmt lint tests
+Lint checks on all
+fail G001 duplicate id "96aa0e17-5e23-4cc3-bc34-88368b8cc07b" in "/tests/tier0/bluechi-agent-connect-via-controller-address"
+fail G001 duplicate id "96aa0e17-5e23-4cc3-bc34-88368b8cc07b" in "/tests/tier0/bluechi-agent-get-logtarget"
 ```
 
 ## Usage of containers

diff --git a/tests/requirements.txt b/tests/requirements.txt
@@ -3,4 +3,4 @@ junit-xml >= 1.9
 pytest >= 7.3.1
 podman >= 4.5.0
 strato-skipper >= 2.0.2
-tmt >= 1.32.1
+tmt >= 1.35
diff --git a/tests/scripts/duplicate-check.py b/tests/scripts/duplicate-check.py