-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increases CI Speed #406
Merged
Merged
Increases CI Speed #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronzi
approved these changes
Sep 9, 2024
FriedJannik
added a commit
to FriedJannik/basyx-java-server-sdk
that referenced
this pull request
Sep 9, 2024
This reverts commit 2e65055.
FriedJannik
added a commit
to FriedJannik/basyx-java-server-sdk
that referenced
this pull request
Sep 9, 2024
This reverts commit 2e65055.
FriedJannik
added a commit
to FriedJannik/basyx-java-server-sdk
that referenced
this pull request
Sep 10, 2024
This reverts commit 2e65055.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit completely changes the CI workflow:
The new workflows are:
There are also some minor changes to some test classes where the dirties context was set to AFTER_EACH_TEST_METHOD, which was not actually required. This setting restarted the context after each test, now with the new AFTER_CLASS setting the context is not restarted, improving test time.
In addition changes were made to the Build Plugins in the parent pom.xml:
The removed plugins are now only in those build processes where they are required
With these changes we can improve the build time by 250% (or from ~30 minutes to ~12 minutes).