Fixes 'same Submodel Reference can be applied to same AAS again without throwing 409' #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronzi
requested changes
Aug 20, 2024
aaronzi
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adding an existing submodel reference now results in a 409 Conflict instead of a 201 Created.
An exception has been added for this (CollidingSubmodelReferenceException).
In addition, there is a new exception for the case where the KeyType is missing, as KeyType is required by spec. (see Metamodel p. 84 -> card. = 1)
Related Issue
Closes #373
BaSyx Configuration for Testing
--
AAS Files Used for Testing
--
Additional Information
--