Added test methods for submodelrepository and submodelservice #335
Conversation
|
|
||
| Submodel retrievedSubmodelMetadata = repo.getSubmodelByIdMetadata(ID); | ||
|
|
||
| assertEquals(expectedSubmodel.getId(), retrievedSubmodelMetadata.getId()); |
There was a problem hiding this comment.
The whole content of the Submodel should be the same and not just ID.
Please correct this.
| public void getSubmodelByIdMetadata() throws JsonProcessingException { | ||
| SubmodelRepository repo = getSubmodelRepository(); | ||
| Submodel expectedSubmodel = buildDummySubmodelWithNoSmElement(ID); | ||
| repo.createSubmodel(expectedSubmodel); |
There was a problem hiding this comment.
A normal Submodel with SM Elements should be created but you can create an expected SM same as per the expected SM returned by the API. So that you can compare the expected and the actual.
| SubmodelValueOnly expectedSmValueOnly = new SubmodelValueOnly(submodelElements); | ||
| SubmodelValueOnly retrievedSmValueOnly = repo.getSubmodelByIdValueOnly(ID); | ||
|
|
||
| assertSameSubmodelValueOnly(expectedSmValueOnly,retrievedSmValueOnly); |
There was a problem hiding this comment.
Why can't we just use assertEquals? bothe are of type SubmodelValueOnly.
Please also correct formatting, use BaSyx formatter if not using.
| assertSameSubmodelValueOnly(expectedSmValueOnly, retrievedSmValueOnly); | ||
| } | ||
|
|
||
| private void assertSameSubmodelValueOnly(SubmodelValueOnly expectedSmValueOnly, |
There was a problem hiding this comment.
Please move this to the end of this class.
The hierarchy of method should always be:
Public
Protected
Private
| SubmodelValueOnly expectedSmValueOnly = new SubmodelValueOnly(submodelElements); | ||
| SubmodelValueOnly retrievedSmValueOnly = repo.getSubmodelByIdValueOnly(ID); | ||
|
|
||
| assertSameSubmodelValueOnly(expectedSmValueOnly, retrievedSmValueOnly); |
There was a problem hiding this comment.
There is already a helper function for what you are doing in this method.
Please use this helper function.
And then remove this assertSameSubmodelValueOnly method.
|
|
||
| Submodel patchedSubmodel = submodelService.getSubmodel(); | ||
|
|
||
| assertEquals(submodel.getSubmodelElements().size(),patchedSubmodel.getSubmodelElements().size()); |
There was a problem hiding this comment.
There is still formatting needed here (there is no space after the comma).
Please use the BaSyx formatter.
|
|
||
| Submodel patchedSubmodel = repo.getSubmodel(ID); | ||
|
|
||
| assertEquals(submodel.getSubmodelElements().size(),patchedSubmodel.getSubmodelElements().size()); |
There was a problem hiding this comment.
There is still formatting needed here (there is no space after the comma).
Please use the BaSyx formatter.
There was a problem hiding this comment.
Please update the License header to 2024
There was a problem hiding this comment.
Please update the license header to 2024
This PR adds missing test methods in the submodelrepository and submodelservice test suite.