Remove observer notifying when creating submodel with the API #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusmolina-iese
force-pushed
the
bug/mongodb-submodel-observer
branch
from
69a3f9a
to
42fb24f
Compare
mateusmolina-iese
changed the title
...ain/java/org/eclipse/basyx/submodel/aggregator/observing/ObservableSubmodelAggregatorV2.java
Show resolved
Hide resolved
mdanish98
suggested changes
Dec 13, 2023
...ite/regression/extensions/submodel/aggregator/mqtt/TestMqttV2SubmodelAggregatorObserver.java
Outdated
Show resolved
Hide resolved
...ite/regression/extensions/submodel/aggregator/mqtt/TestMqttV2SubmodelAggregatorObserver.java
Show resolved
Hide resolved
mdanish98
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Approved, @FrankSchnicke please approve the CI pipeline run.
FrankSchnicke
pushed a commit
that referenced
this pull request
Dec 14, 2023
* Remove notifying when createSubmodel with the submodelAPI * Address review remarks * Add msgCounter to MqttTestListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.