Implement source location matching for weave messages in XML tests #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP (work in progress). Closes #218. Signed-off-by: Alexander Kriegisch <[email protected]>
Remove leading "weaveInfo", add missing "see also:" to weave messages. Relates to #218. Signed-off-by: Alexander Kriegisch <[email protected]>
kriegaex
force-pushed
the
gh-218
branch
2 times, most recently
from
5efe9dc to
9076beb
Compare
Signed-off-by: Alexander Kriegisch <[email protected]>
reference Experimental code leading to undesired ripple effects elsewhere, requiring more rework which now I do not feel inclined to invest to perfect source file string representation for post-compile binary classes and aspects. Relates to #218. Signed-off-by: Alexander Kriegisch <[email protected]>
Instead of creating dedicated ITs for #218, just use the new matching capabilities like this for good measure: <message kind="weave" aspectFile="MyAspect.java" aspectLine="8" .../> Tests affected: - Ajc165Tests::testFunkyPointcut_pr272233_2 - Bugs1920Tests::test_GitHub_214 Relates to #218. Signed-off-by: Alexander Kriegisch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP (work in progress).
@aclement: For now, I committed the solution with extended output via
ISourceLocations, see also #218 (comment). In order for this to work, I had to adjust several tests expecting an exact line-by-line console output instead of selectively matching on weave messages. If I would change this to not passing through source locations but rather directly using file names and lines, I could revert the separate commit updating the expected test outputs, because then the change would be transparent, but also contain less specific information, both internally and on the console.Closes #218.