Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added VAD request capability to server #87

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aabmets
Copy link

@aabmets aabmets commented Jan 4, 2025

@rotemdan Would you be open to accepting this PR, which adds VAD request serving capability to the server and detectVoiceActivity to the client class? I kinda need it for my project.

// Voice activity detection message types
export interface VoiceActivityDetectionRequestMessage extends WorkerMessageBase {
messageType: 'VoiceActivityDetectionRequest'
input: string
Copy link
Author

@aabmets aabmets Jan 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Input type on line 376 is fixed in 97d3b1d

@rotemdan
Copy link
Member

rotemdan commented Jan 4, 2025

Thanks for the contribution. I originally wrote the WebSocket server for mostly TTS serving to a browser extensions. I actually use this server all the time for TTS (via an unpublished extension), but I haven't really made any work on it since it was originally written..

I know it doesn't make much sense to have the WebSocket-based client as part of the main, heavy package. It was actually written mostly for testing the server (I use custom code in the browser extension instead, not based on the Client code at all). Ideally it should be a separate, lightweight package. For that reason I didn't put this on a high priority for development. I don't consider it that usable at the current state.

I'll merge your code but it will require to refresh my memory on something I haven't touched for more than a year now, and didn't have much interest working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants