Checklist Prototypes #5930
Merged
Checklist Prototypes #5930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pmattmann
commented
Sep 16, 2024
•
pmattmann
commented
- Entity
- Repository
- Migration
- Security
- Fixture
- UnitTest
pmattmann
commented
Sep 18, 2024
Comment on lines
+299
to
+313
| if (is_iterable($operation->getUriVariables())) { | ||
| // UriVariable is Link, toProperty is set, fromClass is a entity | ||
| foreach ($operation->getUriVariables() as $uriVariable) { | ||
| if (is_a($uriVariable, Link::class) | ||
| && is_string($uriVariable->getToProperty()) | ||
| && is_a($uriVariable->getFromClass(), HasId::class, true) | ||
| ) { | ||
| // value of toProperty is NULL; Read of its ID will throw Exception | ||
| // -> invalid | ||
| if (null == $entity->{$uriVariable->getToProperty()}) { | ||
| return false; | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
@usu:
Please also direct your focus here
usu
reviewed
Sep 27, 2024
usu
reviewed
Sep 27, 2024
BacLuc
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Tested the api from the browser, it works.
You can use the following script in your local browser against localhost:3004:
https://gist.github.com/BacLuc/8d34ecc1d1544e2e52d6db3895b46903
You need to change the CheckListItemRepository in the following way:
$checklistQry->join(UserCamp::class, 'uc', Join::WITH, 'c.camp = uc.camp OR (c.camp IS NULL AND c.isPrototype = true)');
that an ADMIN can create a nested checklist item for a prototype
Entity, Processor, UnitTests
pmattmann
force-pushed
the
feature/prototype-checklist
branch
from
c49bf35
to
9c389b0
Compare
BacLuc
approved these changes
Sep 27, 2024
usu
reviewed
Sep 28, 2024
usu
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.