campShortTitle.js: fix error for non string camp.shortTitle

Fixes #6363
ecamp · Nov 16, 2024 · 60fd278 · 60fd278
1 parent e89dddd
commit 60fd278
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/common/helpers/__tests__/campShortTitle.spec.js b/common/helpers/__tests__/campShortTitle.spec.js
@@ -37,6 +37,15 @@ describe('campShortTitle', () => {
     [{ shortTitle: undefined, title: null }, ''],
     [{ shortTitle: '0', title: 'Sola24' }, '0'],
     [{ shortTitle: '', title: 'Sola24' }, 'SoLa24'],
+
+    //error cases
+    [{ shortTitle: 0, title: 'Sola24' }, '0'],
+    [{ shortTitle: false, title: 'Sola24' }, 'false'],
+    [{ shortTitle: true, title: 'Sola24' }, 'true'],
+    [{ shortTitle: {}, title: 'Sola24' }, '[object Object]'],
+    [{ shortTitle: Symbol('foo'), title: 'Sola24' }, 'SoLa24'],
+    [{ shortTitle: [], title: 'Sola24' }, ''],
+    [{ shortTitle: /test/, title: 'Sola24' }, '/test/'],
     [null, ''],
     [undefined, ''],
   ])('maps "%s" to "%s"', (input, expected) => {

diff --git a/common/helpers/campShortTitle.js b/common/helpers/campShortTitle.js
@@ -48,8 +48,8 @@ const ADDITIONAL_SHORTNERS = [
 ]
 
 function campShortTitle(camp) {
-  if (camp?.shortTitle != null && camp.shortTitle !== '') {
-    return camp.shortTitle.substring(0, 16)
+  if (camp?.shortTitle != null && camp.shortTitle !== '' && typeof camp.shortTitle !== 'symbol') {
+    return `${camp.shortTitle}`.substring(0, 16)
   }
 
   let title = camp?.title ?? ''