Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TELEMAC Notebook and files #93

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tomsail
Copy link
Collaborator

@tomsail tomsail commented May 31, 2024

Main new feature added:

  • EPSG option (in normalize.py and open_dataset)

Added tests (with Selafin files) for:

  • Default EPSG 4326
  • No EPSG --> no transformation

Bumped up the limit file size in pre-commit

(added jupyter-bokeh in the dev deps too)

@@ -59,6 +59,7 @@ def _resolve_ranges(x_range: tuple[float, float] | None, y_range: tuple[float, f
def open_dataset(
path: str | os.PathLike[str],
normalize: bool = True,
source_crs: int = 4326,
Copy link
Collaborator Author

@tomsail tomsail May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we shouldn't force on the int type here, but I didn't know how to do that.
I don't if we can use pyproj inside (and also for the typing types)

@@ -227,7 +227,7 @@ def normalize_adcirc(ds: xarray.Dataset) -> xarray.Dataset:
}


def normalize(ds: xarray.Dataset) -> xarray.Dataset:
def normalize(ds: xarray.Dataset, source_crs: int = 4326) -> xarray.Dataset:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here for the int type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant