-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added TELEMAC Notebook and files #93
base: master
Are you sure you want to change the base?
Conversation
@@ -59,6 +59,7 @@ def _resolve_ranges(x_range: tuple[float, float] | None, y_range: tuple[float, f | |||
def open_dataset( | |||
path: str | os.PathLike[str], | |||
normalize: bool = True, | |||
source_crs: int = 4326, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we shouldn't force on the int
type here, but I didn't know how to do that.
I don't if we can use pyproj inside (and also for the typing types)
@@ -227,7 +227,7 @@ def normalize_adcirc(ds: xarray.Dataset) -> xarray.Dataset: | |||
} | |||
|
|||
|
|||
def normalize(ds: xarray.Dataset) -> xarray.Dataset: | |||
def normalize(ds: xarray.Dataset, source_crs: int = 4326) -> xarray.Dataset: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here for the int
type
Main new feature added:
normalize.py
andopen_dataset
)Added tests (with Selafin files) for:
Bumped up the limit file size in pre-commit
(added jupyter-bokeh in the dev deps too)