[telemac] addressed reviews and added info in README

README.md

@@ -14,6 +14,7 @@ Thalassa is currently supporting visualization of the output of the following so
 
 - [Schism](https://github.com/schism-dev/schism)
 - [ADCIRC](https://adcirc.org/)
+- [openTELEMAC](https://www.opentelemac.org/)
 
 Adding support for new solvers is relatively straight-forward.
 
@@ -30,6 +31,10 @@ Adding support for new solvers is relatively straight-forward.
 ```
 pip install thalassa
 ```
+for Selafin files (openTELEMAC outputs):
+```
+pip install thalassa[selafin]
+```
 
 ### Conda
 

tests/api_test.py

@@ -18,8 +18,6 @@
         pytest.param(SELAFIN, "S"),
     ],
 )
-
-
 def test_main_api(file, variable):
     ds = api.open_dataset(file)
     assert normalization.is_generic(ds)
@@ -42,9 +40,15 @@ def test_main_api(file, variable):
     hv.render(pointer_ts, backend="bokeh")
 
 
-@pytest.mark.parametrize("variable", [None, "zeta"])
-def test_create_trimesh(variable):
-    ds = api.open_dataset(ADCIRC_NC)
+@pytest.mark.parametrize(
+    "file,variable",
+    [
+        pytest.param(ADCIRC_NC, "zeta"),
+        pytest.param(SELAFIN, "S"),
+    ],
+)
+def test_create_trimesh(file, variable):
+    ds = api.open_dataset(file)
     trimesh = api.create_trimesh(ds, variable=variable)
     assert isinstance(trimesh, gv.TriMesh)
 

thalassa/normalization.py

@@ -110,7 +110,7 @@ def is_adcirc(ds: xarray.Dataset) -> bool:
 def infer_format(ds: xarray.Dataset) -> THALASSA_FORMATS:
     if is_schism(ds):
         fmt = THALASSA_FORMATS.SCHISM
-    if is_telemac(ds):
+    elif is_telemac(ds):
         fmt = THALASSA_FORMATS.TELEMAC
     elif is_pyposeidon(ds):
         fmt = THALASSA_FORMATS.PYPOSEIDON
@@ -176,7 +176,6 @@ def normalize_telemac(ds: xarray.Dataset) -> xarray.Dataset:
         },
     )
     if "plan" in ds.dims:
-        # I.e. OLD Schism IO or "merged" new IO
         ds = ds.rename(
             {
                 "plan": VERTICAL_DIM,