Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Set the default graph on entity creation #5

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Conversation

claudiu-cristea
Copy link
Contributor

No description provided.

@pfrenssen
Copy link
Contributor

No test results?

@pfrenssen
Copy link
Contributor

OK so our test pipeline is not yet configured, and neither @claudiu-cristea or me have the necessary permissions to set up a CI pipeline. This is out of scope for this issue and is handled in #4.

I have added a simple test to verify that the graph is set. Here are the results from running the tests locally:


$ ../vendor/bin/phpunit modules/contrib/sparql_entity_storage/
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.3.10
Configuration: /home/pieter/v/joinup-dev/web/phpunit.xml

....S................                                             21 / 21 (100%)

Time: 33.29 seconds, Memory: 10.00MB

There was 1 skipped test:

1) Drupal\Tests\sparql_entity_storage\Kernel\EncodingTest::testEncoding
Library minimaxir/big-list-of-naughty-strings is required.

/home/pieter/v/joinup-dev/web/modules/contrib/sparql_entity_storage/tests/src/Kernel/EncodingTest.php:25

OK, but incomplete, skipped, or risky tests!
Tests: 21, Assertions: 131, Skipped: 1.

@pfrenssen pfrenssen merged commit 65b3a8f into 8.x-1.x Oct 8, 2019
@pfrenssen pfrenssen deleted the set-default-graph branch October 8, 2019 11:17
pfrenssen pushed a commit that referenced this pull request Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants