Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(drone): automate deployments - EUBFR-146 #197

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kalinchernev
Copy link
Contributor

@kalinchernev kalinchernev commented Feb 20, 2019

PR description

WIP: refactor scripts to rely only on environment variables for AWS credentials. Or find a way for a drone command to use secrets from environment variables without exposing them.

Please refer to https://github.com/ec-europa/eubfr-data-lake/blob/cbf3dc2255f0b731a76d73369ecb6c9cf310ef61/docs/AUTOMATION.md for detailed instructions on how to test.

docs/AUTOMATION.md Outdated Show resolved Hide resolved
docs/AUTOMATION.md Outdated Show resolved Hide resolved
eubfr_content_repository,
]
commands:
- npx serverless config credentials --provider aws --key $${AWS_ACCESS_KEY_ID} --secret $${AWS_SECRET_ACCESS_KEY}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't there a risk of exposing the secrets during the drone deployment here? 🤔

Copy link
Contributor Author

@kalinchernev kalinchernev Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, they are, unfortunately.
I'll probably have to find another way to manage secrets in our scripts (having them as env variables only and not configuring them for .aws system-wide didn't work, adding WIP flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants