Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Release 0.13.0 #47

Merged
merged 8 commits into from
Jan 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
steps:
- uses: actions/setup-node@v3
with:
node-version: '18.x'
node-version: '18.18.2'
- uses: amannn/action-semantic-pull-request@v5
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -27,7 +27,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '18.x'
node-version: '18.18.2'
- name: Test
run: ./scripts/audit.sh
tests:
Expand All @@ -37,7 +37,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '18.x'
node-version: '18.18.2'
- name: Install dependencies
run: yarn install --frozen-lockfile
- name: Build stencil
Expand All @@ -52,7 +52,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '18.x'
node-version: '18.18.2'
- name: Install dependencies
run: yarn install --frozen-lockfile
- name: Package application
Expand All @@ -74,7 +74,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '18.x'
node-version: '18.18.2'
- name: Install dependencies
run: yarn install --frozen-lockfile
- name: Package application
Expand All @@ -96,7 +96,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '18.x'
node-version: '18.18.2'
- name: Install dependencies
run: yarn install --frozen-lockfile
- name: Package application
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18.16.0
v18.18.2
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "0.12.0",
"version": "0.13.0",
"npmClient": "yarn",
"changelog": {
"repo": "ec-europa/ecl-webcomponents",
Expand Down
6 changes: 3 additions & 3 deletions packages/ecl-webcomponents-angular-workspace/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ecl/ecl-webcomponents-angular-workspace",
"version": "0.12.0",
"version": "0.13.0",
"scripts": {
"clean": "rimraf dist",
"ng": "ng",
Expand Down Expand Up @@ -30,8 +30,8 @@
"@angular/cli": "16.2.8",
"@angular/compiler-cli": "16.2.11",
"@babel/plugin-proposal-private-property-in-object": "7.21.11",
"@ecl/ecl-webcomponents": "0.12.0",
"@ecl/ecl-webcomponents-angular": "0.12.0",
"@ecl/ecl-webcomponents": "0.13.0",
"@ecl/ecl-webcomponents-angular": "0.13.0",
"browser-sync": "3.0.2",
"express": "4.18.2",
"karma": "~6.4.0",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ecl/ecl-webcomponents-angular",
"version": "0.12.0",
"version": "0.13.0",
"publishConfig": {
"access": "public"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/ecl-webcomponents-react-consumer/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@ecl/ecl-webcomponents-react-consumer",
"private": true,
"version": "0.12.0",
"version": "0.13.0",
"type": "module",
"scripts": {
"clean": "rimraf dist",
Expand All @@ -12,7 +12,7 @@
"pre-publish": "npm run build"
},
"dependencies": {
"@ecl/ecl-webcomponents-react": "0.12.0",
"@ecl/ecl-webcomponents-react": "0.13.0",
"react": "18.2.0",
"react-dom": "18.2.0",
"rimraf": "5.0.5"
Expand Down
4 changes: 2 additions & 2 deletions packages/ecl-webcomponents-react/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ecl/ecl-webcomponents-react",
"version": "0.12.0",
"version": "0.13.0",
"description": "ECL react app",
"main": "lib/index.ts",
"module": "dist/index.js",
Expand All @@ -27,7 +27,7 @@
"access": "public"
},
"dependencies": {
"@ecl/ecl-webcomponents": "0.12.0"
"@ecl/ecl-webcomponents": "0.13.0"
},
"devDependencies": {
"@types/react": "18.2.48",
Expand Down
2 changes: 1 addition & 1 deletion packages/ecl-webcomponents/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ecl/ecl-webcomponents",
"version": "0.12.0",
"version": "0.13.0",
"description": "ECL web components",
"license": "EUPL-1.2",
"main": "dist/index.cjs.js",
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
diff --git a/node_modules/@ecl/vanilla-component-accordion/accordion.js b/node_modules/@ecl/vanilla-component-accordion/accordion.js
index 85141a9..f06232d 100644
index 08c5b16..cd41037 100644
--- a/node_modules/@ecl/vanilla-component-accordion/accordion.js
+++ b/node_modules/@ecl/vanilla-component-accordion/accordion.js
@@ -131,14 +131,21 @@ export class Accordion {
@@ -138,14 +138,21 @@ export class Accordion {
if (iconElement) {
const useNode = queryOne('use', iconElement);
if (useNode) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
diff --git a/node_modules/@ecl/vanilla-component-carousel/carousel.js b/node_modules/@ecl/vanilla-component-carousel/carousel.js
index 3e1dc99..08cdab4 100644
index f37281d..6b799b9 100644
--- a/node_modules/@ecl/vanilla-component-carousel/carousel.js
+++ b/node_modules/@ecl/vanilla-component-carousel/carousel.js
@@ -131,6 +131,8 @@ export class Carousel {
@@ -136,6 +136,8 @@ export class Carousel {
this.direction = getComputedStyle(this.element).direction;

this.slides = queryAll(this.slideClass, this.element);
+ this.slidesContainer.innerHTML = '';
+ this.slidesContainer.append(...this.slides);
this.total = this.slides.length;

// If only one slide, don't initialize carousel and hide controls
// If only one slide, don't initialize carousel and hide controls
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
diff --git a/node_modules/@ecl/vanilla-component-category-filter/category-filter.js b/node_modules/@ecl/vanilla-component-category-filter/category-filter.js
index 76b4353..ed7da7d 100644
index a1d3c09..d48617c 100644
--- a/node_modules/@ecl/vanilla-component-category-filter/category-filter.js
+++ b/node_modules/@ecl/vanilla-component-category-filter/category-filter.js
@@ -90,21 +90,24 @@ export class CategoryFilter {
@@ -96,21 +96,24 @@ export class CategoryFilter {

const treeItem = e.target.closest('.ecl-category-filter__item');

Expand Down Expand Up @@ -33,7 +33,7 @@ index 76b4353..ed7da7d 100644
if (item === treeItem) {
item.classList.add('ecl-category-filter__item--current');
} else {
@@ -112,11 +115,7 @@ export class CategoryFilter {
@@ -118,11 +121,7 @@ export class CategoryFilter {
}
});

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
diff --git a/node_modules/@ecl/vanilla-component-content-block/content-block.js b/node_modules/@ecl/vanilla-component-content-block/content-block.js
index 6913470..ee23ad4 100644
index e231bd7..72de3e9 100644
--- a/node_modules/@ecl/vanilla-component-content-block/content-block.js
+++ b/node_modules/@ecl/vanilla-component-content-block/content-block.js
@@ -72,7 +72,7 @@ export class ContentBlock {
@@ -77,7 +77,7 @@ export class ContentBlock {
}

this.title = queryOne(this.titleSelector, this.element);
Expand Down
13 changes: 13 additions & 0 deletions patches/@ecl+vanilla-component-select+3.13.0.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/node_modules/@ecl/vanilla-component-select/select.js b/node_modules/@ecl/vanilla-component-select/select.js
index af9c468..5696a1a 100644
--- a/node_modules/@ecl/vanilla-component-select/select.js
+++ b/node_modules/@ecl/vanilla-component-select/select.js
@@ -495,7 +495,7 @@ export class Select {
}
this.visibleOptions = this.checkboxes;

- this.select.parentNode.parentNode.insertBefore(
+ this.select.closest('.ecl-form-group').insertBefore(
this.selectMultiple,
this.select.parentNode.nextSibling,
);
2 changes: 1 addition & 1 deletion playground/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@ecl/web-components-playground",
"author": "European Commission",
"license": "EUPL-1.2",
"version": "0.12.0",
"version": "0.13.0",
"description": "ECL web components playground",
"main": "index.html",
"private": true,
Expand Down
26 changes: 20 additions & 6 deletions src/components.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -284,18 +284,22 @@ export namespace Components {
"theme": string;
}
interface EclFormGroup {
"ariaLabelOptional": string;
"ariaLabelRequired": string;
"helperId": string;
"helperText": string;
"invalid": boolean;
"invalidIcon": string;
"invalidText": string;
"label": string;
"labelClass": string;
"labelTag": string;
"name": string;
"optionalText": string;
"required": boolean;
"requiredText": string;
"styleClass": string;
"tag": string;
"theme": string;
}
interface EclGallery {
Expand Down Expand Up @@ -382,7 +386,6 @@ export namespace Components {
"disabled": boolean;
"eclScript": boolean;
"hasChanged": boolean;
"helperId": string;
"helperText": string;
"inputClass": string;
"inputId": string;
Expand Down Expand Up @@ -462,6 +465,7 @@ export namespace Components {
"eclScript": boolean;
"group": string;
"maxLines": number;
"menuId": string;
"menuLink": string;
"menuTitle": string;
"nextLabel": string;
Expand Down Expand Up @@ -644,6 +648,7 @@ export namespace Components {
"disabled": boolean;
"helperId": string;
"helperText": string;
"inputDefaultValue": string;
"inputId": string;
"invalid": boolean;
"invalidText": string;
Expand All @@ -660,8 +665,8 @@ export namespace Components {
"disabled": boolean;
"eclScript": boolean;
"hasChanged": boolean;
"inputValue": string;
"invalid": boolean;
"isFocused": boolean;
"multiple": boolean;
"multipleAllText": string;
"multipleClearAllText": string;
Expand Down Expand Up @@ -760,8 +765,10 @@ export namespace Components {
"theme": string;
}
interface EclTextarea {
"defaultValue": string;
"disabled": boolean;
"hasChanged": boolean;
"inputId": string;
"invalid": boolean;
"isFocused": boolean;
"name": string;
Expand Down Expand Up @@ -1049,7 +1056,7 @@ declare global {
interface HTMLEclInputElementEventMap {
"inputFocus": FocusEvent;
"inputBlur": FocusEvent;
"inputChange": any;
"inputChange": { type: string; value: string };
}
interface HTMLEclInputElement extends Components.EclInput, HTMLStencilElement {
addEventListener<K extends keyof HTMLEclInputElementEventMap>(type: K, listener: (this: HTMLEclInputElement, ev: EclInputCustomEvent<HTMLEclInputElementEventMap[K]>) => any, options?: boolean | AddEventListenerOptions): void;
Expand Down Expand Up @@ -1706,18 +1713,22 @@ declare namespace LocalJSX {
"theme"?: string;
}
interface EclFormGroup {
"ariaLabelOptional"?: string;
"ariaLabelRequired"?: string;
"helperId"?: string;
"helperText"?: string;
"invalid"?: boolean;
"invalidIcon"?: string;
"invalidText"?: string;
"label"?: string;
"labelClass"?: string;
"labelTag"?: string;
"name"?: string;
"optionalText"?: string;
"required"?: boolean;
"requiredText"?: string;
"styleClass"?: string;
"tag"?: string;
"theme"?: string;
}
interface EclGallery {
Expand Down Expand Up @@ -1804,7 +1815,6 @@ declare namespace LocalJSX {
"disabled"?: boolean;
"eclScript"?: boolean;
"hasChanged"?: boolean;
"helperId"?: string;
"helperText"?: string;
"inputClass"?: string;
"inputId"?: string;
Expand All @@ -1813,7 +1823,7 @@ declare namespace LocalJSX {
"label"?: string;
"name"?: string;
"onInputBlur"?: (event: EclInputCustomEvent<FocusEvent>) => void;
"onInputChange"?: (event: EclInputCustomEvent<any>) => void;
"onInputChange"?: (event: EclInputCustomEvent<{ type: string; value: string }>) => void;
"onInputFocus"?: (event: EclInputCustomEvent<FocusEvent>) => void;
"placeholder"?: string;
"required"?: boolean;
Expand Down Expand Up @@ -1887,6 +1897,7 @@ declare namespace LocalJSX {
"eclScript"?: boolean;
"group"?: string;
"maxLines"?: number;
"menuId"?: string;
"menuLink"?: string;
"menuTitle"?: string;
"nextLabel"?: string;
Expand Down Expand Up @@ -2075,6 +2086,7 @@ declare namespace LocalJSX {
"disabled"?: boolean;
"helperId"?: string;
"helperText"?: string;
"inputDefaultValue"?: string;
"inputId"?: string;
"invalid"?: boolean;
"invalidText"?: string;
Expand All @@ -2091,8 +2103,8 @@ declare namespace LocalJSX {
"disabled"?: boolean;
"eclScript"?: boolean;
"hasChanged"?: boolean;
"inputValue"?: string;
"invalid"?: boolean;
"isFocused"?: boolean;
"multiple"?: boolean;
"multipleAllText"?: string;
"multipleClearAllText"?: string;
Expand Down Expand Up @@ -2194,8 +2206,10 @@ declare namespace LocalJSX {
"theme"?: string;
}
interface EclTextarea {
"defaultValue"?: string;
"disabled"?: boolean;
"hasChanged"?: boolean;
"inputId"?: string;
"invalid"?: boolean;
"isFocused"?: boolean;
"name"?: string;
Expand Down
Loading