Skip to content

Commit

Permalink
feat(form-elements): Adding default value for input fields where missing
Browse files Browse the repository at this point in the history
  • Loading branch information
planctus committed Jan 18, 2024
1 parent d8c097c commit 1b0a4c5
Show file tree
Hide file tree
Showing 20 changed files with 97 additions and 280 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
steps:
- uses: actions/setup-node@v3
with:
node-version: '18.x'
node-version: '18.8.2'
- uses: amannn/action-semantic-pull-request@v5
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -27,7 +27,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '18.x'
node-version: '18.8.2'
- name: Test
run: ./scripts/audit.sh
tests:
Expand All @@ -37,7 +37,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '18.x'
node-version: '18.8.2'
- name: Install dependencies
run: yarn install --frozen-lockfile
- name: Build stencil
Expand All @@ -52,7 +52,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '18.x'
node-version: '18.8.2'
- name: Install dependencies
run: yarn install --frozen-lockfile
- name: Package application
Expand All @@ -74,7 +74,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '18.x'
node-version: '18.8.2'
- name: Install dependencies
run: yarn install --frozen-lockfile
- name: Package application
Expand All @@ -96,7 +96,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '18.x'
node-version: '18.8.2'
- name: Install dependencies
run: yarn install --frozen-lockfile
- name: Package application
Expand Down
67 changes: 0 additions & 67 deletions patches/@ecl+builder+3.11.0.patch

This file was deleted.

19 changes: 0 additions & 19 deletions patches/@ecl+theme-dev+3.11.0.patch

This file was deleted.

29 changes: 0 additions & 29 deletions patches/@ecl+vanilla-component-accordion+3.11.0.patch

This file was deleted.

15 changes: 0 additions & 15 deletions patches/@ecl+vanilla-component-button+3.11.0.patch

This file was deleted.

12 changes: 0 additions & 12 deletions patches/@ecl+vanilla-component-card+3.11.0.patch

This file was deleted.

13 changes: 0 additions & 13 deletions patches/@ecl+vanilla-component-carousel+3.11.0.patch

This file was deleted.

48 changes: 0 additions & 48 deletions patches/@ecl+vanilla-component-category-filter+3.11.0.patch

This file was deleted.

13 changes: 0 additions & 13 deletions patches/@ecl+vanilla-component-content-block+3.11.0.patch

This file was deleted.

13 changes: 13 additions & 0 deletions patches/@ecl+vanilla-component-select+3.13.0.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/node_modules/@ecl/vanilla-component-select/select.js b/node_modules/@ecl/vanilla-component-select/select.js
index af9c468..5696a1a 100644
--- a/node_modules/@ecl/vanilla-component-select/select.js
+++ b/node_modules/@ecl/vanilla-component-select/select.js
@@ -495,7 +495,7 @@ export class Select {
}
this.visibleOptions = this.checkboxes;

- this.select.parentNode.parentNode.insertBefore(
+ this.select.closest('.ecl-form-group').insertBefore(
this.selectMultiple,
this.select.parentNode.nextSibling,
);
8 changes: 6 additions & 2 deletions src/components.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -648,6 +648,7 @@ export namespace Components {
"disabled": boolean;
"helperId": string;
"helperText": string;
"inputDefaultValue": string;
"inputId": string;
"invalid": boolean;
"invalidText": string;
Expand All @@ -664,8 +665,8 @@ export namespace Components {
"disabled": boolean;
"eclScript": boolean;
"hasChanged": boolean;
"inputValue": string;
"invalid": boolean;
"isFocused": boolean;
"multiple": boolean;
"multipleAllText": string;
"multipleClearAllText": string;
Expand Down Expand Up @@ -764,6 +765,7 @@ export namespace Components {
"theme": string;
}
interface EclTextarea {
"defaultValue": string;
"disabled": boolean;
"hasChanged": boolean;
"inputId": string;
Expand Down Expand Up @@ -2084,6 +2086,7 @@ declare namespace LocalJSX {
"disabled"?: boolean;
"helperId"?: string;
"helperText"?: string;
"inputDefaultValue"?: string;
"inputId"?: string;
"invalid"?: boolean;
"invalidText"?: string;
Expand All @@ -2100,8 +2103,8 @@ declare namespace LocalJSX {
"disabled"?: boolean;
"eclScript"?: boolean;
"hasChanged"?: boolean;
"inputValue"?: string;
"invalid"?: boolean;
"isFocused"?: boolean;
"multiple"?: boolean;
"multipleAllText"?: string;
"multipleClearAllText"?: string;
Expand Down Expand Up @@ -2203,6 +2206,7 @@ declare namespace LocalJSX {
"theme"?: string;
}
interface EclTextarea {
"defaultValue"?: string;
"disabled"?: boolean;
"hasChanged"?: boolean;
"inputId"?: string;
Expand Down
6 changes: 1 addition & 5 deletions src/components/ecl-range/ecl-range.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,6 @@ export class EclRange {
}
}

handleInput(event) {
this.value = event.target.value;
}

handleFocus(event) {
this.inputFocus.emit(event);
this.isFocused = true;
Expand Down Expand Up @@ -142,7 +138,7 @@ export class EclRange {
>
<input
{...attributes}
onInput={ev => this.handleInput(ev)}
onInput={ev => this.handleChange(ev)}
onFocus={ev => this.handleFocus(ev)}
onBlur={ev => this.handleBlur(ev)}
onChange={ev => this.handleChange(ev)}
Expand Down
2 changes: 2 additions & 0 deletions src/components/ecl-search-form/ecl-search-form.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export class EclSearchForm {
@Prop() helperText: string;
@Prop() placeholder: string;
@Prop() inputId: string;
@Prop() inputDefaultValue: string;
@Prop() width: string = 'm';
@Prop() label: string;
@Prop() type: string;
Expand Down Expand Up @@ -58,6 +59,7 @@ export class EclSearchForm {
invalid={this.invalid}
width="m"
placeholder={this.placeholder}
default-value={this.inputDefaultValue}
>
</ecl-input>
</ecl-form-group>
Expand Down
Loading

0 comments on commit 1b0a4c5

Please sign in to comment.