Issue #58: Constructs struct with protected ctor with () rather than {} #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base class of the struct has a protected constructor so this commit uses parens instead of brackets for regular construction in both C++14 and 17, rather than aggregate construction in 17. See the following for details. https://stackoverflow.com/questions/56367480/should-this-code-fail-to-compile-in-c17
|
thanks, merged in 8f6c176 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base class of the struct has a protected constructor so this commit uses parens instead of brackets for regular construction in both C++14 and 17, rather than aggregate construction in 17. See the following for details.
https://stackoverflow.com/questions/56367480/should-this-code-fail-to-compile-in-c17
For issue #58