Fix warnings #272
Merged
Fix warnings #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsjbailey
force-pushed
the
fix_warnings
branch
2 times, most recently
from
8d898f5 to
42c494f
Compare
Adds a cmake function for marking include directories as system on an existing target. Applies that function to the VST3 sdk targets that were producing a lot of warnings. Additionally silences all warnings when building submodules by appending "-w" flag (gcc/clang) both via CMAKE_CXX_FLAGS and directly on the ffts target (it has specific warnings added via visr, so we need to make sure -w is the last option)
This silences the redefinition warnings when building tests
This was actually a spurious warning as we were intentionally defining functions to determine their type, but using an explicit type alias works just as well.
This function could result in Undefined Behaviour as there was no return value in one path.
This change is just to silence a warning about unhandled enums. NNG_PIPE_EV_NUM is just there so you can determine the number of pipe events, it shouldn't ever actually be used, so this change should have no effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a number of warnings from dependencies and within the EPS
On macos with xcode 15 there are still spurious warnings about duplicate libraries during linking. This is due to a change in Apple's linker and will be fixed in the next release of CMake.
The remaining warnings about unhandled enums are useful, as they highlight areas of the code where we're currently choosing not to implement functionality, so I've not touched those.