Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HasMany improvements #442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HasMany improvements #442

wants to merge 1 commit into from

Conversation

Sergio-Mira
Copy link

  • Setting a has many array with the same array must not trigger its observers
  • Loading collections with same element twice must not trigger observers

We solved this issues in our fork to avoid a huge Ember component from being re-drawn and also prevents the collections from being dirty when there have been no changes, which means less http requests.

Thanks for the lib!

@Sergio-Mira Sergio-Mira changed the title Prevent triggering has many relationships when there are no changes HasMany improvements Nov 26, 2015
@Sergio-Mira
Copy link
Author

Any way this can be reviewed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sergio-Mira