-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
object output from PAGA plotting #226
Conversation
Could we smuggle here the change of the last citation to our nature methods?
I tried committing it myself, but for some reason it doesn't allow me to write to it ¿?. |
We appear to be suffering from issues like those reported in galaxyproject/planemo#1078. Trying to think of a way of working around them here. |
I think the MNN issues preventing the CI passing are down to a numpy problem- I've tried to apply a fix in a new build of scanpy scripts bioconda/bioconda-recipes#27908 |
Okay, we can't actually skip single tools yet (see galaxyproject/planemo-ci-action#13). @pcm32 the test for MNN passes locally, and the trajectory plotting passes here (which is what this PR should be about). Can we override the CI and merge this for now, in the interests of getting this functionality out there? I don't have more time to spend on the MNN instruction error thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please bump the version to reflect the scanpy version as suggested.
echo "Unsuccessful tests found, inspect the 'All tool test results' artifact for details." | ||
exit 1 | ||
fi | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make a note that the copy from FTP code is here.
Okay, looking good now I think. I'll keep an eye and see if the deploy works, of if I'll have to update as I've done in pr.yaml. |
Description
This is the Galaxy component of ebi-gene-expression-group/scanpy-scripts#95. Essentially configuring the PAGA plotting to output an object alongside the plotfile, which can then be used for initialising FDG.
Fixes # (issue)
Type of change
Checklist
@TOOL_VERSION@
), then I have reset all 'build' values to 0 (e.g.@TOOL_VERSION@+galaxy0
)@TOOL_VERSION@+galaxy0
@TOOL_VERSION@+galaxy1
)