Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scxa-cell-type-wheel-experiment-heatmap/bugfix/encode-slash-for-cell-type #175

Conversation

upendrakumbham
Copy link
Contributor

Fix for the front end(web app) and backend endpoint (API) to accept / in the cell type

Endpoint - /json/cell-type-marker-genes/{cellType}

@upendrakumbham upendrakumbham marked this pull request as draft September 25, 2024 10:59
@upendrakumbham upendrakumbham self-assigned this Sep 25, 2024
@ke4 ke4 added the bug Something isn't working label Sep 25, 2024
@upendrakumbham upendrakumbham marked this pull request as ready for review October 1, 2024 16:12
Copy link
Contributor

@ke4 ke4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work.
I added some tiny suggestions for you change.
Could you please review and apply them?
Thanks

upendrakumbham and others added 2 commits October 2, 2024 10:33
Co-authored-by: Károly Erdős <[email protected]>
Signed-off-by: upendrakumbham <[email protected]>
ke4
ke4 previously approved these changes Oct 2, 2024
Copy link
Contributor

@ke4 ke4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your work!

 - @ebi-gene-expression-group/[email protected]
Copy link
Contributor

@ke4 ke4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, I am going to approve it.
All I ask is to add [Bugfix] prefix when you merge it to the merge's commit message.
Thanks

@upendrakumbham upendrakumbham merged commit bdcfe7c into master Oct 4, 2024
@upendrakumbham upendrakumbham deleted the scxa-cell-type-wheel-experiment-heatmap/bugfix/encode-slash-for-cell-type branch October 4, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants