-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scxa-cell-type-wheel-experiment-heatmap/bugfix/encode-slash-for-cell-type #175
scxa-cell-type-wheel-experiment-heatmap/bugfix/encode-slash-for-cell-type #175
Conversation
Signed-off-by: upendrakumbham <[email protected]>
Signed-off-by: upendrakumbham <[email protected]>
Signed-off-by: upendrakumbham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work.
I added some tiny suggestions for you change.
Could you please review and apply them?
Thanks
...xa-cell-type-wheel-experiment-heatmap/cypress/component/CellTypeWheelExperimentHeatmap.cy.js
Outdated
Show resolved
Hide resolved
...xa-cell-type-wheel-experiment-heatmap/cypress/component/CellTypeWheelExperimentHeatmap.cy.js
Outdated
Show resolved
Hide resolved
packages/scxa-cell-type-wheel-experiment-heatmap/src/CellTypeWheelExperimentHeatmap.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Károly Erdős <[email protected]>
Signed-off-by: upendrakumbham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for your work!
- @ebi-gene-expression-group/[email protected]
Signed-off-by: upendrakumbham <[email protected]>
- @ebi-gene-expression-group/[email protected]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me, I am going to approve it.
All I ask is to add [Bugfix]
prefix when you merge it to the merge's commit message.
Thanks
Fix for the front end(web app) and backend endpoint (API) to accept / in the cell type
Endpoint
- /json/cell-type-marker-genes/{cellType}