Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove degrees_of_freedom methods #998

Merged
merged 6 commits into from
Jul 23, 2024
Merged

remove degrees_of_freedom methods #998

merged 6 commits into from
Jul 23, 2024

Conversation

strengejacke
Copy link
Member

No description provided.

@strengejacke
Copy link
Member Author

@vincentarelbundock I don't know if you call degrees_of_freedom() in one of your packages - it's now completely moved to insight::get_df(). From a user perspective, nothing should have changed. But since all methods were removed here and degrees_of_freedom() just calls insight::get_df() now, there may be new errors not detected yet.

My question: once this PR is merged, could you test your packages (I'm particularly thinking of modelsummary) with the GitHub version of parameters?

@strengejacke
Copy link
Member Author

Oh, and of course the GitHub version of insight.

@strengejacke strengejacke merged commit 5b8e7a8 into main Jul 23, 2024
19 of 20 checks passed
@strengejacke strengejacke deleted the remove_dof branch July 23, 2024 22:20
@vincentarelbundock
Copy link
Contributor

Thanks for the heads-up. I think I had already moved everything to get_df(), so this should be no problem. I ran the test suite locally with Github versions of all easystats packages I depend on, and didn't seen any error.

Consolidation is a good move here. Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants