Bail out on list insertion of non-Node

PhpStan correctly detected that this is not supported. We could add support for it, but for now just make sure it doesn't crash.
easysoft · Sep 17, 2022 · f7b448f · f7b448f
1 parent b3ad14b
commit f7b448f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/PhpParser/PrettyPrinterAbstract.php b/lib/PhpParser/PrettyPrinterAbstract.php
@@ -830,6 +830,11 @@ protected function pArray(
                     return null;
                 }
 
+                if (!$arrItem instanceof Node) {
+                    // We only support list insertion of nodes.
+                    return null;
+                }
+
                 // We go multiline if the original code was multiline,
                 // or if it's an array item with a comment above it.
                 // Match always uses multiline formatting.

diff --git a/test/code/formatPreservation/listInsertion.test b/test/code/formatPreservation/listInsertion.test
@@ -345,4 +345,12 @@ function test() {
     $a;
     $b;
     $z;
-}
+}
+-----
+<?php
+list($x, $y) = $z;
+-----
+array_splice($stmts[0]->expr->var->items, 1, 0, [null]);
+-----
+<?php
+list($x, , $y) = $z;