Fix trait alias to semi-reserved name parsing

This was missing the explicit construction of an Identifier node.
easysoft · Oct 29, 2017 · b241a12 · b241a12
1 parent 5054a68
commit b241a12
Show file tree

Hide file tree

Showing 5 changed files with 1,565 additions and 1,530 deletions.
diff --git a/grammar/php5.y b/grammar/php5.y
@@ -44,6 +44,10 @@ identifier:
       T_STRING                                              { $$ = Node\Identifier[$1]; }
 ;
 
+reserved_non_modifiers_identifier:
+      reserved_non_modifiers                                { $$ = Node\Identifier[$1]; }
+;
+
 namespace_name_parts:
       T_STRING                                              { init($1); }
     | namespace_name_parts T_NS_SEPARATOR T_STRING          { push($1, $3); }
@@ -484,7 +488,7 @@ trait_adaptation:
           { $$ = Stmt\TraitUseAdaptation\Alias[$1[0], $1[1], $3, null]; }
     | trait_method_reference T_AS identifier ';'
           { $$ = Stmt\TraitUseAdaptation\Alias[$1[0], $1[1], null, $3]; }
-    | trait_method_reference T_AS reserved_non_modifiers ';'
+    | trait_method_reference T_AS reserved_non_modifiers_identifier ';'
           { $$ = Stmt\TraitUseAdaptation\Alias[$1[0], $1[1], null, $3]; }
 ;
 

diff --git a/grammar/php7.y b/grammar/php7.y
@@ -44,6 +44,10 @@ identifier:
       T_STRING                                              { $$ = Node\Identifier[$1]; }
 ;
 
+reserved_non_modifiers_identifier:
+      reserved_non_modifiers                                { $$ = Node\Identifier[$1]; }
+;
+
 namespace_name_parts:
       T_STRING                                              { init($1); }
     | namespace_name_parts T_NS_SEPARATOR T_STRING          { push($1, $3); }
@@ -544,7 +548,7 @@ trait_adaptation:
           { $$ = Stmt\TraitUseAdaptation\Alias[$1[0], $1[1], $3, null]; }
     | trait_method_reference T_AS identifier ';'
           { $$ = Stmt\TraitUseAdaptation\Alias[$1[0], $1[1], null, $3]; }
-    | trait_method_reference T_AS reserved_non_modifiers ';'
+    | trait_method_reference T_AS reserved_non_modifiers_identifier ';'
           { $$ = Stmt\TraitUseAdaptation\Alias[$1[0], $1[1], null, $3]; }
 ;