Skip to content

Commit

Permalink
Use PhpStan level 6
Browse files Browse the repository at this point in the history 
New baseline errors are array types that I prefer to leave alone,
as well as one PhpStan bug:
phpstan/phpstan#4526
  • Loading branch information
@nikic
nikic committed Sep 17, 2022
1 parent f98341f commit 9f9c2ea
Show file tree
Hide file tree
Showing 2 changed files with 121 additions and 1 deletion.
120 changes: 120 additions & 0 deletions phpstan-baseline.neon
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,100 @@
parameters:
ignoreErrors:
-
message: "#^Method PhpParser\\\\Builder\\\\ClassConst\\:\\:__construct\\(\\) has parameter \\$value with no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/Builder/ClassConst.php

-
message: "#^Method PhpParser\\\\Builder\\\\ClassConst\\:\\:addConst\\(\\) has parameter \\$value with no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/Builder/ClassConst.php

-
message: "#^Method PhpParser\\\\BuilderFactory\\:\\:args\\(\\) has parameter \\$args with no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/BuilderFactory.php

-
message: "#^Method PhpParser\\\\BuilderFactory\\:\\:attribute\\(\\) has parameter \\$args with no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/BuilderFactory.php

-
message: "#^Method PhpParser\\\\BuilderFactory\\:\\:classConst\\(\\) has parameter \\$value with no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/BuilderFactory.php

-
message: "#^Method PhpParser\\\\BuilderFactory\\:\\:funcCall\\(\\) has parameter \\$args with no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/BuilderFactory.php

-
message: "#^Method PhpParser\\\\BuilderFactory\\:\\:methodCall\\(\\) has parameter \\$args with no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/BuilderFactory.php

-
message: "#^Method PhpParser\\\\BuilderFactory\\:\\:new\\(\\) has parameter \\$args with no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/BuilderFactory.php

-
message: "#^Method PhpParser\\\\BuilderFactory\\:\\:staticCall\\(\\) has parameter \\$args with no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/BuilderFactory.php

-
message: "#^Method PhpParser\\\\BuilderFactory\\:\\:val\\(\\) has parameter \\$value with no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/BuilderFactory.php

-
message: "#^Method PhpParser\\\\BuilderHelpers\\:\\:normalizeValue\\(\\) has parameter \\$value with no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/BuilderHelpers.php

-
message: "#^Method PhpParser\\\\ConstExprEvaluator\\:\\:evaluateArray\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/ConstExprEvaluator.php

-
message: "#^Unary operation \"~\" on mixed results in an error\\.$#"
count: 1
path: lib/PhpParser/ConstExprEvaluator.php

-
message: "#^Method PhpParser\\\\Internal\\\\TokenPolyfill\\:\\:fixupBadCharacters\\(\\) has parameter \\$origTokens with no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/Internal/TokenPolyfill.php

-
message: "#^Method PhpParser\\\\Internal\\\\TokenPolyfill\\:\\:fixupBadCharacters\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/Internal/TokenPolyfill.php

-
message: "#^Method PhpParser\\\\JsonDecoder\\:\\:decodeArray\\(\\) has parameter \\$array with no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/JsonDecoder.php

-
message: "#^Method PhpParser\\\\JsonDecoder\\:\\:decodeArray\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/JsonDecoder.php

-
message: "#^Method PhpParser\\\\JsonDecoder\\:\\:decodeComment\\(\\) has parameter \\$value with no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/JsonDecoder.php

-
message: "#^Method PhpParser\\\\JsonDecoder\\:\\:decodeNode\\(\\) has parameter \\$value with no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/JsonDecoder.php

-
message: "#^Call to function assert\\(\\) with false will always evaluate to false\\.$#"
count: 1
Expand All @@ -15,6 +105,31 @@ parameters:
count: 1
path: lib/PhpParser/Lexer/TokenEmulator/NumericLiteralSeparatorEmulator.php

-
message: "#^Method PhpParser\\\\NodeDumper\\:\\:__construct\\(\\) has parameter \\$options with no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/NodeDumper.php

-
message: "#^Method PhpParser\\\\NodeDumper\\:\\:dump\\(\\) has parameter \\$node with no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/NodeDumper.php

-
message: "#^Method PhpParser\\\\NodeDumper\\:\\:dumpRecursive\\(\\) has parameter \\$node with no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/NodeDumper.php

-
message: "#^Method PhpParser\\\\NodeTraverser\\:\\:traverseArray\\(\\) has parameter \\$nodes with no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/NodeTraverser.php

-
message: "#^Method PhpParser\\\\NodeTraverser\\:\\:traverseArray\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
path: lib/PhpParser/NodeTraverser.php

-
message: "#^Access to an undefined property PhpParser\\\\Node\\:\\:\\$attrGroups\\.$#"
count: 1
Expand Down Expand Up @@ -130,6 +245,11 @@ parameters:
count: 1
path: lib/PhpParser/ParserAbstract.php

-
message: "#^Property PhpParser\\\\ParserAbstract\\:\\:\\$createdArrays \\(SplObjectStorage\\<PhpParser\\\\Node\\\\Expr\\\\Array_, null\\>\\|null\\) does not accept SplObjectStorage\\<object, mixed\\>\\.$#"
count: 1
path: lib/PhpParser/ParserAbstract.php

-
message: "#^Unary operation \"\\+\" on string results in an error\\.$#"
count: 1
Expand Down
2 changes: 1 addition & 1 deletion phpstan.neon.dist
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ includes:
- phpstan-baseline.neon

parameters:
level: 5
level: 6
paths:
- lib
treatPhpDocTypesAsCertain: false

0 comments on commit 9f9c2ea

Please sign in to comment.