enhance get_software_libdir to return full paths if requested
#4699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm only hesitant in case this creates some annoying merge conflict with 5.0.x, i don't want to block that in any way as we just must get that going |
|
At least 5.0x can be merged into this branch, so I hope its fine the other way round later. |
|
@Flamefire Can you re-target this to |
This avoids the need to do something like `os.path.join(get_software_root(foo), get_software_libdir(foo))`
Flamefire
force-pushed
the
fullpath-libdir
branch
from
d244f74 to
f8dde63
Compare
Flamefire
force-pushed
the
fullpath-libdir
branch
from
f8dde63 to
f35ae5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the need to do something like
os.path.join(get_software_root(foo), get_software_libdir(foo))Also removed an extra indent for readability: The
if root: <long codeblock> else: return Nonegets easier to read when swapped avoiding theelse