Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'source' step to 'extract' (affects skipsteps easyconfig parameter + --stop option) #4629

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Sep 11, 2024

Adjust tests to take that into account and add tests to check that the
old name causes a proper error.
Add such error handling for the skipsteps EC parameter.

Split up test_skip into more focused sub tests to allow adding the new (negative/failure) test of skipsteps to one of those.

Also a fix for test_compiler_cache and a bit cleanup to avoid copying the same superflous parameters in the new tests.

Fixes #4627

@Flamefire Flamefire force-pushed the source-step branch 2 times, most recently from c8f9611 to 2945e38 Compare September 11, 2024 15:08
@boegel boegel added change EasyBuild-5.0 EasyBuild 5.0 labels Sep 11, 2024
@boegel boegel added this to the 5.0 milestone Sep 11, 2024
@Flamefire Flamefire force-pushed the source-step branch 3 times, most recently from 9847816 to 375b04d Compare September 12, 2024 08:21
@boegel
Copy link
Member

boegel commented Sep 25, 2024

@Flamefire Merge conflict to fix, probably a trivial one...

```
'--sourcepath=%s' % self.test_sourcepath,
'--buildpath=%s' % self.test_buildpath,
'--installpath=%s' % self.test_installpath,
```
is not required because the test setup sets those via env variables.
Adjust tests to take that into account and add tests to check that the
old name causes a proper error.
Add such error handling for the `skipsteps` EC parameter.
Split up `test_skip` into more focused sub tests.
This fixes `test_toy_multi_deps` which restores the environment in the
middle of the test and then misses the --sourcepath modification done at test setup.
@Flamefire
Copy link
Contributor Author

Jep, one of the test fixes I had opened a separate PR for

@boegel boegel changed the title Rename SOURCE_STEP to EXTRACT_STEP Rename 'source' step to 'extract' Dec 4, 2024
@boegel boegel changed the title Rename 'source' step to 'extract' Rename 'source' step to 'extract' (affects skipsteps easyconfig parameter + --stop option) Dec 4, 2024
@boegel boegel enabled auto-merge December 4, 2024 15:46
@boegel boegel merged commit 5a2f3e8 into easybuilders:5.0.x Dec 4, 2024
38 of 39 checks passed
@Flamefire Flamefire deleted the source-step branch December 19, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants