don't allow unresolved templates in easyconfig parameters by default + add support for --allow-unresolved-templates configuration option
#4516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
disallow-template-failure
branch
3 times, most recently
from
604053a to
4a73b73
Compare
Flamefire
force-pushed
the
disallow-template-failure
branch
3 times, most recently
from
145defc to
eaaf115
Compare
|
@Flamefire Can you sync this with the current |
boegel
changed the title
--allow-unresolved-templates configuration option
Flamefire
force-pushed
the
disallow-template-failure
branch
from
eaaf115 to
a6cc123
Compare
|
CI finished after the sync as requested. |
A failure in template resolving is currently hidden in the log although it is likely due to a bug in the code (either EasyBuild, EasyBlock or EasyConfig) This may lead to cryptic error messages later on or misbehave silently which is even worse.
If we only want the `len` of some list we don't need to resolve the templates. We cannot resolve templates in collect_exts_file_info like `installdir` present in e.g. `installcmd` of the extension options.
…ions & `asdict` Some dependencies may use templates referring to other dependencies which cannot yet be resolved. Hence add an opt-out to the enforcment of resolved templates via `expect_resolved=False` and use that. This allows use of `%(installdir)s` or `%(ext_name)s` and similar in the options.
…hat use False as default value
Flamefire
force-pushed
the
disallow-template-failure
branch
from
7c8f4cb to
bc6a136
Compare
|
Rebased and fixed the 2 style issues. BTW: For 5.0x we can use |
Flamefire
force-pushed
the
disallow-template-failure
branch
from
bc6a136 to
4e21bc9
Compare
…est to check on resolving of template values
Flamefire
force-pushed
the
disallow-template-failure
branch
from
4e21bc9 to
b426aaa
Compare
boegel
approved these changes
Dec 18, 2024
This was referenced Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A failure in template resolving is currently hidden in the log although
it is likely due to a bug in the code (either EasyBuild, EasyBlock or EasyConfig)
This may lead to cryptic error messages later on or misbehave silently
which is even worse.