Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only install GitHub token when testing with Lmod 8.x + Python 3.6 or 3.9 #4375

Merged
merged 1 commit into from
Nov 5, 2023
Merged

only install GitHub token when testing with Lmod 8.x + Python 3.6 or 3.9 #4375

merged 1 commit into from
Nov 5, 2023

Conversation

boegel
Copy link
Member

@boegel boegel commented Nov 5, 2023

fixes #4372

@boegel boegel added this to the next release (4.9.0?) milestone Nov 5, 2023
migueldiascosta
migueldiascosta approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta migueldiascosta merged commit 685467c into easybuilders:develop Nov 5, 2023
39 checks passed
@boegel boegel deleted the github_tests_ci_token branch November 5, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees
No one assigned
Labels
bug fix tests
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.

GitHub tests fail in CI because we're hitting GitHub API rate limit
2 participants
@boegel @migueldiascosta