Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken test for reasons_for_closing, which fails because commit status of easyconfigs PR is no longer available #4366

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Oct 27, 2023

This test started failing because the commit status in easybuilders/easybuild-easyconfigs#16080 has been "reset" (GitHub only still provides commit status for sufficiently recent PRs/commits).

We don't care much about the commit status in the test for reasons_for_closing, so easiest way to deal with this is to just stop checking the commit status...

…tatus of easyconfigs PR is no longer available
@branfosj branfosj enabled auto-merge October 27, 2023 09:30
@branfosj branfosj merged commit 6fccffe into easybuilders:develop Oct 27, 2023
39 checks passed
@boegel boegel deleted the fix_test_github_reasons_for_closing branch October 27, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants