fix findPythonDeps.py script when called with an (absolute or relative) path to an easyconfig instead of a filename
#4365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`eb --missing` returns a list with filenames. So an absolute path passed to `--ec` isn't matched which leads to an error stating you should install the EasyConfig that you are trying to find the dependencies of. Fix by getting the filename/basename first.
…aptured This helps diagnosing failures for e.g. `eb --missing` (called with `capture_stderr=False`) but which may print errors (e.g. failed parsing of some ECs) to stderr
boegel
changed the title
findPythonDeps.py script when called with an absolute path to an EC
boegel
changed the title
findPythonDeps.py script when called with an absolute path to an ECfindPythonDeps.py script when called with an absolute path to an easyconfig
Flamefire
changed the title
findPythonDeps.py script when called with an absolute path to an easyconfigfindPythonDeps.py script when called with an (absolute or relative) path to an easyconfig instead of a filename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eb --missingreturns a list with filenames. So an absolute path passed to--ecisn't matched which leads to an error stating you should install the EasyConfig that you are trying to find the dependencies of. Fix by getting the filename/basename first.Example error: