-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CI workflow to run unit tests with Python 2 (again) #4333
Conversation
…ges when testing with Python 2
…udo -u easybuild bash -l -c ...`
…ompatible with both (old versions of) Python 2.7 & 3.x
…ts with Python 2.7 in CentOS 7.9 container
Down to 4 failing tests, probably due to side-effects caused by running the test suite via
|
As suggested by @branfosj, I've skipped the 4 tests that are broken when running on top of Python 2 for now in c3fc220, so we can get this merged rather than spending more time to figure out why the tests are only broken with Python 2. Very likely the problem with those tests is specific to using Python 2 in a nice feature of EasyBuild (like |
We stopped testing with Python 2 in #4267 because official support for using Python 2 was dropped in both GitHub Actions and
actions/setup-python
.That has led to silently introducing bugs that make EasyBuild crash hard when running on top of Python 2 however, see for example #4328.
While support for running EasyBuild on top of Python 2 is deprecated (since EasyBuild 4.7.0 - Jan'23, cfr. #4136), we should do what we can to maintain compatibility with Python 2 until EasyBuild 5.0 is released.