Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make REST client actually return headers when http method is HEAD #2763

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

migueldiascosta
Copy link
Member

ported from hpcugent/vsc-base#276

(not sure where to put the test now)

@boegel boegel added this to the 4.0 milestone Feb 13, 2019
@boegel
Copy link
Member

boegel commented Feb 13, 2019

@migueldiascosta W.r.t. your question on the test: the tests for the modules ingested from vsc-base were not copied into the framework repository.

I think that's OK for now, since we will have tests for the EasyBuild functionality that relies on the easybuild.base.* modules anyway.

Another option is to start a new test/framework/base.py test suite to cover changes/fixes made in easybuild.base.*.

In this case however, the change made here well eventually be covered (indirectly) via #2553, so I think it's fine.

@migueldiascosta
Copy link
Member Author

@boegel yeah, those were precisely the options I was wondering about, and I agree that either way it should be fine

@boegel
Copy link
Member

boegel commented Feb 13, 2019

Thanks for the backport @migueldiascosta!

@boegel boegel merged commit 0862138 into easybuilders:4.x Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants