Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove -m64 compiler flag for non-x86-64 CPU architectures in SIONlib 1.7.7 easyconfigs #21752

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

bedroge
Copy link
Contributor

@bedroge bedroge commented Oct 28, 2024

This flag is not supported for (many) other CPU architectures, e.g. on Arm64 it will throw errors like:

gcc: error: unrecognized command-line option -m64

It may even be fine to remove it for x86-64 as well, since it only seems to be useful when cross-compiling for a 64-bit machine on a 32-bit machine?

@bedroge bedroge added bug fix EESSI Related to EESSI project aarch64 Related to Arm 64-bit (aarch64) riscv labels Oct 28, 2024
@bedroge
Copy link
Contributor Author

bedroge commented Oct 29, 2024

@boegelbot please test @ generoso

@bedroge
Copy link
Contributor Author

bedroge commented Oct 29, 2024

Test report by @bedroge
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
bob-Latitude-5300 - Linux Ubuntu 24.04.1 LTS (Noble Numbat), x86_64, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, Python 3.12.3
See https://gist.github.com/bedroge/e3cb8e55baddeba096b0b4afdca9c8af for a full test report.

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on login1

PR test command 'EB_PR=21752 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21752 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14589

Test results coming soon (I hope)...

- notification for comment with ID 2443649889 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/0eeec0cb19c5d34a6e685686132ad539 for a full test report.

@bedroge
Copy link
Contributor Author

bedroge commented Oct 29, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21752 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21752 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5170

Test results coming soon (I hope)...

- notification for comment with ID 2444152558 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/5d132b31b4d9d6be99a39f67edf81b2b for a full test report.

@Thyre
Copy link
Contributor

Thyre commented Oct 29, 2024

It may even be fine to remove it for x86-64 as well, since it only seems to be useful when cross-compiling for a 64-bit machine on a 32-bit machine?

I asked around and got the following answer:

As far as I'm aware, it should be. As they say, it's mostly only relevant for cross-compiling. I think it's fine to accept.

@ocaisa
Copy link
Member

ocaisa commented Oct 29, 2024

All builds in EESSI/software-layer#797 (that were affected by this issue) passed with these changes

@ocaisa ocaisa merged commit 4468e15 into easybuilders:develop Oct 29, 2024
9 checks passed
@bedroge bedroge deleted the fix_sionlib_non_x86-64_archs branch October 29, 2024 13:48
@boegel boegel added this to the release after 4.9.4 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch64 Related to Arm 64-bit (aarch64) bug fix EESSI Related to EESSI project riscv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants