Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance easyconfigs for gnuplot 5.4.x to make sure that Lua dependency is always used #19261

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Nov 18, 2023

(created using eb --new-pr)

This fixes a build problem we observed in EESSI, caused by mixing of the Lua 5.1 that is provided by the EESSI compat layer and the Lua 5.4 dependency provided via EasyBuild.

term.o:term.c:function LUA_dashtype: error: undefined reference to 'lua_pcallk'
term.o:term.c:function LUA_dashtype: error: undefined reference to 'lua_tonumberx'

see also EESSI/software-layer#380)

@boegel boegel added bug fix EESSI Related to EESSI project labels Nov 18, 2023
@boegel boegel added this to the next release (4.9.0?) milestone Nov 18, 2023
@boegel
Copy link
Member Author

boegel commented Nov 18, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=19261 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19261 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12189

Test results coming soon (I hope)...

- notification for comment with ID 1817480583 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
cns3 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/976afee8d873f847c7713e39a519cd31 for a full test report.

@bedroge
Copy link
Contributor

bedroge commented Nov 18, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19261 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19261 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3755

Test results coming soon (I hope)...

- notification for comment with ID 1817496224 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/9633b62f380308feca282e4824863fcb for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 18, 2023

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3120.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/6e3ddb89cd1b8d3638e8688a08d6acba for a full test report.

Copy link
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bedroge
Copy link
Contributor

bedroge commented Nov 18, 2023

Going in, thanks @boegel!

@bedroge bedroge merged commit ca324a5 into easybuilders:develop Nov 18, 2023
9 checks passed
@boegel boegel deleted the 20231118121554_new_pr_gnuplot541 branch November 18, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix EESSI Related to EESSI project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants