Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use pip to install mympingpong + add sanity check command to catch broken installation #11583

Closed

Conversation

boegel
Copy link
Member

@boegel boegel commented Oct 28, 2020

(created using eb --new-pr)
shouldn't use pip because it breaks the vsc.* namespace (see hpcugent/vsc-install#68)

@lexming lexming added this to the 4.x milestone Oct 29, 2020
@lexming
Copy link
Contributor

lexming commented Oct 29, 2020

Test report by @lexming
SUCCESS
Build succeeded for 8 out of 8 (2 easyconfigs in total)
node101.hydra.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/7ea618c99e8f497cd8afb4e2f49ba54f for a full test report.

@lexming
Copy link
Contributor

lexming commented Oct 29, 2020

Test report by @lexming
SUCCESS
Build succeeded for 8 out of 8 (2 easyconfigs in total)
node368.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/67b370ff2a03778dd804341d8d8ddc92 for a full test report.

@boegel boegel modified the milestones: 4.x, 4.3.2 Oct 31, 2020
@boegel
Copy link
Member Author

boegel commented Oct 31, 2020

Test report by @boegel
FAILED
Build succeeded for 9 out of 13 (2 easyconfigs in total)
node3104.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/f00d91be166311a9d7747392fbff588e for a full test report.

@boegel
Copy link
Member Author

boegel commented Oct 31, 2020

Test report by @boegel
FAILED
Build succeeded for 5 out of 7 (2 easyconfigs in total)
node2498.golett.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/a412877a5af84fe3131b00f1ec2713b3 for a full test report.

@boegelbot
Copy link
Collaborator

@boegel: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/339419106
Output from first failing test suite run:

FAIL: test_changed_files_pull_request (test.easyconfigs.easyconfigs.EasyConfigTest)
Specific checks only done for the (easyconfig) files that were changed in a pull request.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 807, in test_changed_files_pull_request
    self.check_python_packages(changed_ecs, added_ecs_filenames)
  File "test/easyconfigs/easyconfigs.py", line 644, in check_python_packages
    self.assertFalse(failing_checks, '\n'.join(failing_checks))
AssertionError: 'use_pip' should be set in vsc-base-2.8.3.eb
'use_pip' should be set in vsc-install-0.17.1.eb

----------------------------------------------------------------------
Ran 10810 tests in 926.956s

FAILED (failures=1)
ERROR: Not all tests were successful.

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice you me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@boegel boegel modified the milestones: 4.3.2 (next release), 4.4.0 Dec 8, 2020
@boegel boegel modified the milestones: next release (4.3.3?), 4.x Feb 19, 2021
@jfgrimm
Copy link
Member

jfgrimm commented Jun 21, 2023

Test report by @jfgrimm
FAILED
Build succeeded for 7 out of 13 (4 easyconfigs in total)
himem06.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Platinum 8160 CPU @ 2.10GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/jfgrimm/9bc5491db13da7ad453cbc8906853b77 for a full test report.

@akesandgren
Copy link
Contributor

Closing this PR, since it (only) uses deprecated toolchain versions,
see https://docs.easybuild.io/policies/toolchains .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants