Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code supporting obsolete versions from IntelBase family of easyblocks + remove unused custom easyblock for IPP #3533

Open
wants to merge 18 commits into
base: 5.0.x
Choose a base branch
from

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Dec 17, 2024

Remove code from IntelBase easyblock and its derivatives that is specific to obsolete versions or features:

  • remove m32 support
  • remove usetmppath support
  • remove specific support for versions prior to 2020.x

List of affected easyblocks:

  • a/advisor.py
  • generic/intelbase.py
  • i/icc.py
  • i/ifort.py
  • i/imkl.py
  • i/impi.py
  • i/inspector.py
  • i/intel_compilers.py
  • i/ipp.py (removed)
  • i/itac.py
  • t/tbb.py
  • v/vtune.py

@lexming lexming added this to the 5.0 milestone Dec 17, 2024
@lexming lexming changed the title Cleanup old intelbase Remove code from IntelBase family of easyblock supporting obsolete versions Dec 17, 2024
@lexming lexming changed the title Remove code from IntelBase family of easyblock supporting obsolete versions Remove code supporting obsolete versions from IntelBase family of easyblocks Dec 17, 2024
@boegel
Copy link
Member

boegel commented Dec 18, 2024

ipp.py can be removed, since we don't have easyconfigs anymore for it in 5.0.x branch

@boegel boegel changed the title Remove code supporting obsolete versions from IntelBase family of easyblocks Remove code supporting obsolete versions from IntelBase family of easyblocks + remove unused custom easyblock for IPP Dec 18, 2024
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of code to review, but lgtm i think

@boegel boegel changed the title Remove code supporting obsolete versions from IntelBase family of easyblocks + remove unused custom easyblock for IPP Remove code supporting obsolete versions from IntelBase family of easyblocks + remove unused custom easyblock for IPP Dec 18, 2024
@lexming
Copy link
Contributor Author

lexming commented Dec 18, 2024

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS iccifort-2020.4.304.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node302.hydra.os - Linux Rocky Linux 8.10, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/lexming/fbe976723ae403ce875e667e3ddb5ba3 for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Dec 19, 2024

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS impi-2019.9.304-iccifort-2020.4.304.eb
  • SUCCESS impi-2019.12.320-iccifort-2020.4.304.eb
  • SUCCESS impi-2021.6.0-intel-compilers-2022.1.0.eb
  • SUCCESS impi-2021.9.0-intel-compilers-2023.1.0.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
node301.hydra.os - Linux Rocky Linux 8.10, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/lexming/fbe64d50e0cc53cd9092ff2d33488a6f for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Dec 20, 2024

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS imkl-2020.4.304-gompi-2020b.eb
  • SUCCESS imkl-2021.2.0-gompi-2021a.eb
  • SUCCESS imkl-2022.1.0-gompi-2022a.eb
  • SUCCESS imkl-2023.1.0-gompi-2023a.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
node300.hydra.os - Linux Rocky Linux 8.10, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/lexming/c1aeea72895a34d59bcb4b8c3f648db5 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Breaking changes
Development

Successfully merging this pull request may close these issues.

3 participants