Add support for STAR-CCM+ installs with .aol installer #3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoors
reviewed
Dec 19, 2024
| "-DINSTALL_LICENSING=false", | ||
| "-DADDSYSTEMPATH=false", | ||
| self.cfg['installopts'], | ||
| "&& mv %s/%s %s" % (self.builddir, self.version, self.installdir), |
There was a problem hiding this comment.
for the -r8 variant, suffix -R8 is added to this directory. simplest solution is to add a wildcard:
Suggested change
| "&& mv %s/%s %s" % (self.builddir, self.version, self.installdir), | |
| "&& mv %s/%s* %s" % (self.builddir, self.version, self.installdir), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Siemens has introduced
.aolinstallers for their clang-compiled distributions.Relevant installation Changes:
2410, their clang compiled distributions are.aolexecutables. Other distributions seemed to keep the usual tarball format (which include a.shinstall script). However, STAR-CCM+ compiled with the GCC will no longer be available starting with version2506.2410_008is19.06.008), but .aol use the user facing version in its name.