replace run_cmd with run_shell_cmd in custom easyblock for ATLAS (atlas.py)
#3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branfosj
changed the title
run_cmd with run_shell_cmd in atlas.pyrun_cmd with run_shell_cmd in custom easyblock for ADF (atlas.py)
branfosj
changed the title
run_cmd with run_shell_cmd in custom easyblock for ADF (atlas.py)run_cmd with run_shell_cmd in custom easyblock for ATLAS (atlas.py)
boegel
requested changes
Jan 29, 2024
|
|
||
| if exitcode != 0: | ||
| if res.code != 0: |
There was a problem hiding this comment.
Suggested change
| if res.code != 0: | |
| if res.exit_code != 0: |
There was a problem hiding this comment.
easybuilders/easybuild-docs#240 for updating the documentation to avoid someone else making the same mistake I made here.
|
@branfosj Last stable release of ATLAS was in 2016, and I doubt we'll get new easyconfigs for this soon, so maybe this is another easyblock we want to simply retire for EasyBuild 5.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)ATLASeasyconfigsEB_ATLASin easyconfigs or blocks