-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use correct TCL configure options for Python 3.11+ #3087
use correct TCL configure options for Python 3.11+ #3087
Conversation
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
@Flamefire The test reports should be for It seems like that isn't actually causing real problems up until now, since the Tcl & Tk dependencies are being picked up just fine when these We should fix it of course, just wondering why we haven't really bumped into trouble here... |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
|
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
@branfosj all good, ready to merge? |
Going in, thanks @Flamefire! |
Then we don't need to set those configureopts at all. #3025 detects that those are (now) unused. Not setting the options/variables runs the risk of picking up a system installed Tcl/Tk which seems to be why those options were added in the easyblock. |
(created using
eb --new-pr
)See https://docs.python.org/3/whatsnew/3.11.html