Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct TCL configure options for Python 3.11+ #3087

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Jan 23, 2024

(created using eb --new-pr)

See https://docs.python.org/3/whatsnew/3.11.html

Note Use the environment variables TCLTK_CFLAGS and TCLTK_LIBS to manually specify the location of Tcl/Tk headers and libraries. The configure options --with-tcltk-includes and --with-tcltk-libs have been removed.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • SUCCESS Tk-8.6.13-GCCcore-12.3.0.eb
  • SUCCESS Tkinter-3.11.3-GCCcore-12.3.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
taurusml2 - Linux RHEL 7.6, POWER, 8335-GTX (power9le), 6 x NVIDIA Tesla V100-SXM2-32GB, 440.64.00, Python 2.7.5
See https://gist.github.com/Flamefire/3468f6de06fd7c7c50962c83634b73f9 for a full test report.

@boegel boegel added the bug fix label Jan 29, 2024
@boegel boegel modified the milestones: 5.0, release after 4.9.0 Jan 29, 2024
@boegel
Copy link
Member

boegel commented Jan 29, 2024

@Flamefire The test reports should be for Python itself, no?

It seems like that isn't actually causing real problems up until now, since the Tcl & Tk dependencies are being picked up just fine when these $TCLTK_* environment variables are not set?

We should fix it of course, just wondering why we haven't really bumped into trouble here...

@boegel
Copy link
Member

boegel commented Jan 29, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Python-3.10.8-GCCcore-12.2.0.eb
  • SUCCESS Python-3.11.2-GCCcore-12.2.0-bare.eb
  • SUCCESS Python-3.11.3-GCCcore-12.3.0.eb
  • SUCCESS Python-3.11.5-GCCcore-13.2.0.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
node3147.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/67f984b6e32ea68337ff1639e6316cfd for a full test report.

@branfosj
Copy link
Member

@Flamefire The test reports should be for Python itself, no?

It seems like that isn't actually causing real problems up until now, since the Tcl & Tk dependencies are being picked up just fine when these $TCLTK_* environment variables are not set?

We should fix it of course, just wondering why we haven't really bumped into trouble here...

Tkinter should be tested - https://github.com/easybuilders/easybuild-easyblocks/blob/develop/easybuild/easyblocks/t/tkinter.py#L47

@branfosj
Copy link
Member

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS Tkinter-2.7.18-GCCcore-11.2.0.eb
  • SUCCESS Tkinter-3.10.8-GCCcore-12.2.0.eb
  • SUCCESS Tkinter-3.11.3-GCCcore-12.3.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/bc4bb985076b33be5aee3203ac1af191 for a full test report.

@boegel
Copy link
Member

boegel commented Jan 29, 2024

@branfosj all good, ready to merge?

@branfosj
Copy link
Member

Going in, thanks @Flamefire!

@branfosj branfosj merged commit 3c53615 into easybuilders:develop Jan 29, 2024
47 checks passed
@Flamefire
Copy link
Contributor Author

It seems like that isn't actually causing real problems up until now, since the Tcl & Tk dependencies are being picked up just fine when these $TCLTK_* environment variables are not set?

We should fix it of course, just wondering why we haven't really bumped into trouble here...

Then we don't need to set those configureopts at all. #3025 detects that those are (now) unused. Not setting the options/variables runs the risk of picking up a system installed Tcl/Tk which seems to be why those options were added in the easyblock.

@Flamefire Flamefire deleted the 20240123131007_new_pr_python branch February 3, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants