Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix specifying path to SuiteSparse header files and libraries in numpy, Trilinos, PETSc easyblocks #3056

Merged
merged 3 commits into from
Dec 29, 2023
Merged

fix specifying path to SuiteSparse header files and libraries in numpy, Trilinos, PETSc easyblocks #3056

merged 3 commits into from
Dec 29, 2023

Conversation

appolloford
Copy link
Contributor

@appolloford appolloford commented Dec 18, 2023 •
edited by boegel
Loading

(created using eb --new-pr)

PR #3004 changed the install path of suitesparse. Some easyblocks were not updated and caused problems mentioned in #3051. I can find suitesparse appears in numpy.py, trilinos.py, dolfin.py, elsi.py, petsc.py. It looks that the corresponding easyconfigs of dolfin and elsi have not been updated for years. I update only numpy.py, trilinos.py, petsc.py in this PR.

edit (by @boegel): fixes #3051

@appolloford appolloford force-pushed the 20231218172153_new_pr_numpy branch from 4e76351 to d3e9e53 Compare December 18, 2023 17:40
@boegel boegel added the bug fix label Dec 20, 2023
@boegel boegel added this to the next release (4.9.0?) milestone Dec 20, 2023
@boegel boegel changed the title Fix suitesparse path fix SuiteSparse path in numpy, Trilinos, PETSc easyblocks Dec 20, 2023
@boegel boegel changed the title fix SuiteSparse path in numpy, Trilinos, PETSc easyblocks fix specifying path to SuiteSparse header files and libraries in numpy, Trilinos, PETSc easyblocks Dec 29, 2023
@boegel boegel force-pushed the 20231218172153_new_pr_numpy branch from 6ce5326 to 66e2ba8 Compare December 29, 2023 10:05
@boegel
Copy link
Member

boegel commented Dec 29, 2023 •
edited
Loading

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS SuperLU_DIST-8.1.0-foss-2022a.eb
  • SUCCESS MATIO-1.5.23-GCCcore-11.3.0.eb
  • SUCCESS PETSc-3.17.4-foss-2022a.eb
  • SUCCESS GLM-0.9.9.8-GCCcore-11.3.0.eb
  • SUCCESS Trilinos-13.4.1-foss-2022a.eb

Build succeeded for 5 out of 5 (2 easyconfigs in total)
node3123.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/983948f6c8d319f46abd9d5b453b7386 for a full test report.

edit: this was on top of an existing SuiteSparse installation that was using old directory structure (so not using #3004)

@boegel
Copy link
Member

boegel commented Dec 29, 2023

SciPy-bundle easyconfigs don't include SuiteSparse dependency, so I'll skip the test for numpy easyblock (but I did review the proposed changes in detail, should work fine when SuiteSparse is used as dependency for numpy)

boegel
boegel approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Dec 29, 2023 •
edited
Loading

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Trilinos-13.4.1-foss-2022a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3158.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/721178ceec5d290e671d9e58a53311e0 for a full test report.

edit: tested on top of SuiteSparse that was installed with updated easyblock from #3004

@boegel
Copy link
Member

boegel commented Dec 29, 2023 •
edited
Loading

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS SuperLU_DIST-8.1.0-foss-2022a.eb
  • SUCCESS PETSc-3.17.4-foss-2022a.eb

Build succeeded for 2 out of 2 (1 easyconfigs in total)
node3144.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/e67f44f03517a7172ae571f9fd79571e for a full test report.

edit: tested on top of SuiteSparse that was installed with updated easyblock from #3004

@boegel boegel merged commit 82373f2 into easybuilders:develop Dec 29, 2023
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.

Latest suitesparse easyblock modified library paths and doesn't install CSparse libs
2 participants
@appolloford @boegel