Skip to content

Commit

Permalink
fix type check in generic Bundle easyblock
Browse files Browse the repository at this point in the history
  • Loading branch information
lexming committed Nov 10, 2024
1 parent be989f8 commit 92a5007
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions easybuild/easyblocks/generic/bundle.py
Original file line number Diff line number Diff line change
Expand Up @@ -324,15 +324,14 @@ def install_step(self):

def make_module_req_guess(self):
"""
Set module requirements from all comppnents, e.g. $PATH, etc.
Set module requirements from all components, e.g. $PATH, etc.
During the install step, we only set these requirements temporarily.
Later on when building the module, those paths are not considered.
Therefore, iterate through all the components again and gather
the requirements.
Do not remove duplicates or check for existance of folders,
as this is done in the generic EasyBlock while creating
the modulefile already.
as this is done while creating the modulefile already.
"""
# Start with the paths from the generic EasyBlock.
# If not added here, they might be missing entirely and fail sanity checks.
Expand All @@ -344,7 +343,7 @@ def make_module_req_guess(self):

try:
for key, value in sorted(reqs.items()):
if isinstance(reqs, string_type):
if isinstance(reqs, str):
value = [value]
final_reqs.setdefault(key, [])
final_reqs[key] += value
Expand Down

0 comments on commit 92a5007

Please sign in to comment.