Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split out default config changes and remove proposed changes for EasyBuild v5.0 #242

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

branfosj
Copy link
Member

This:

  • splits out the changes to default configuration from enhancements
  • removes the proposed changes section, as we've closed feedback on the proposals we had

@branfosj branfosj added the EasyBuild-5.0 EasyBuild 5.0 label Feb 16, 2024
@@ -1,9 +0,0 @@
# Proposed changes for EasyBuild v5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with no longer linking to this page, but ideally we don't remove it, and just put pointers to the new location where this info is available (I really dislike hitting broken URLs that were working before)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest redirecting it to the EB5 index instead: 5495612

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title split out default config changes and remove proposed changes split out default config changes and remove proposed changes for EasyBuild v5.0 Mar 13, 2024
@boegel boegel merged commit 118ddcc into easybuilders:develop Mar 13, 2024
4 checks passed
@branfosj branfosj deleted the config branch March 18, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EasyBuild-5.0 EasyBuild 5.0
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants