call finish script before deleting oldest release and handle delete e…

…rrors sanely

src/handler/finish_handler.rs

@@ -3,7 +3,7 @@ use crate::entity::options::Options;
 use crate::handler::call_followup_lifecycle_script;
 use crate::handler::release_discard::discord_oldest_release;
 use crate::helper::process_helper::CommandResult;
-use log::info;
+use log::{error, info};
 use std::path::Path;
 use symlink::{remove_symlink_dir, symlink_dir};
 
@@ -13,7 +13,16 @@ pub(crate) async fn finish_deployment(
 ) -> anyhow::Result<Option<CommandResult>, anyhow::Error> {
  let deploy_base_dir = info.base_directory();
  let result = internal_finish_deployment(options, info).await;
- call_followup_lifecycle_script(&deploy_base_dir, "publish", result).await
+ let finish_script_result =
+ call_followup_lifecycle_script(&deploy_base_dir, "publish", result).await;
+
+ // cleanup (by removing the oldest release)
+ info!("Published one release, trying to discord the oldest release");
+ if let Err(error) = discord_oldest_release(options) {
+ error!("Unable to delete oldest release: {}", error);
+ }
+
+ finish_script_result
 }
 
 async fn internal_finish_deployment(
@@ -28,9 +37,5 @@ async fn internal_finish_deployment(
  remove_symlink_dir(&deployment_link_path).ok();
  symlink_dir(deployment_dir, deployment_link_path)?;
 
- // cleanup (by removing the oldest release)
- info!("Published one release, trying to discord the oldest release");
- discord_oldest_release(options)?;
-
  Ok(())
 }