Prune ref IDs and cache key digests #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejholly
force-pushed
the
mh/next-prune-ids
branch
2 times, most recently
from
e7edfd8
to
a6f87b0
Compare
alexcb
approved these changes
May 24, 2024
mikejholly
force-pushed
the
mh/next-prune-ids
branch
from
a6f87b0
to
7d8c917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds code for ref ID garbage collection & improves memory uses around cache key generation.
worker/simple.goWorkerResultSourcehas a new prune function that purges stale ref IDs (every 30 mins)cacheKeyManageris build-specific & can be created (and disposed of) on a per-build basisCore tests: earthly/earthly#4147